Help in DFS/Topological Sort

[himanshupc11]

https://pastebin.com/izXcLa3x(Link to the code)

Hello guys this is my first time trying to implement a DFS/Topological sort on the question MAKETREE-Hierarchy. On inputting the test case my code gets stuck in an infinite loop between edge 1 and edge 3 because edge 3 isnt getting popped off. Please help me understand why this is happening and a hint to fixing it is appreciated

[simes]

while(!myStack.empty())
{
for(auto itr = adjList[myStack.top()].begin(); itr != adjList[myStack.top()].end(); ++itr)
{
if(visited[*itr] == false)
{
visited[*itr] = true;
myStack.push(*itr); <---- 1
…
}
}
…
myStack.pop(); <---- 2
}

You’re pushing something onto the stack at line marked 1, then popping it back off again at the line marked 2. Instead, you should be popping the original item off the stack before you enter the loop.

[himanshupc11]

But isn’t dfs implemented this way "Unless all nodes are explored it shouldn’t be popped of the stack"
So i should not pop the original one unless it has no unvisited neighbours

Also After pushing second value (3) as it doesn’t have any neighbours it should get popped but it isn’t popping off